git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/10] commit-graph: several refactorings for writing commit graphs

From
Derrick Stolee <stolee@gmail.com>
Date
Nov 5, 2026, 15:18 UTC
Message-ID
<ca5986e3-8f66-4628-9f06-eb2416378bef@gmail.com>
In-Reply-To
<auyLRZ8TWeqdIaRm@pks.im>
On 11/5/2026 8:57 AM, Patrick Steinhardt wrote:
Show 18 quoted lines
> On Wed, Nov 04, 2026 at 11:37:11AM -0500, Derrick Stolee wrote:
>> On 11/4/2026 10:57 AM, Patrick Steinhardt wrote:
>>> Hi,
>>>
>>> this patch series includes several small cleanups for the interfaces for
>>> writing commit graphs. Most importantly, the series refactors options so
>>> that they all get passed via `struct commit_graph_write_options`. These
>>> cleanups are split out of a bigger change to make reading and writing
>>> commit-graphs pluggable via the object database bakcend.
>> These cleanups look great. They are carefully constructed to be as
>> simple as possible at each step. It's good to bring some of these
>> conventions into a more modern style and to simplify things in the
>> process.
> 
> Ah, by the way, one thing I forgot: I noticed this recently already, but
> you don't reply-to-all and thus lose the Cc's on your replies. That made
> me miss a couple of your replies already, so I'd appreciate it if you
> could keep them.

Sorry about that. I learned that Thunderbird replaced the "Reply All" button with a "Reply List" button that led to this unintentional behavior. I'll figure out how to change that default.

Thanks, -Stolee

Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 21 of 22 in “commit-graph: several refactorings for writing commit graphs”
  1. 00/10 commit-graph: several refactorings for writing commit graphsPatrick Steinhardt, Nov 4, 2026
  2. 01/10 commit-graph: rename `struct commit_graph_opts`Patrick Steinhardt, Nov 4, 2026
  3. 02/10 commit-graph: pass writer flags via optionsPatrick Steinhardt, Nov 4, 2026
  4. 03/10 commit-graph: drop `NULL` checks for write optionsPatrick Steinhardt, Nov 4, 2026
  5. 04/10 commit-graph: drop redundant flags in write contextPatrick Steinhardt, Nov 4, 2026
  6. Junio C HamanoNov 4, 2026
  7. 05/10 commit-graph: merge the two commit graph writersPatrick Steinhardt, Nov 4, 2026
  8. Derrick StoleeNov 4, 2026
  9. 06/10 commit-graph: move remaining write parameters into optionsPatrick Steinhardt, Nov 4, 2026
  10. Derrick StoleeNov 4, 2026
  11. Kristofer KarlssonNov 4, 2026
  12. Patrick SteinhardtNov 5, 2026
  13. Kristofer KarlssonNov 5, 2026
  14. 07/10 commit-graph: fix mixup of write/verify flagsPatrick Steinhardt, Nov 4, 2026
  15. 08/10 builtin/commit-graph: set flags directlyPatrick Steinhardt, Nov 4, 2026
  16. 09/10 odb/source-files: verify commit-graphs as part of fsckPatrick Steinhardt, Nov 4, 2026
  17. 10/10 commit-graph: modernize function namesPatrick Steinhardt, Nov 4, 2026
  18. Derrick StoleeNov 4, 2026
  19. Patrick SteinhardtNov 5, 2026
  20. Patrick SteinhardtNov 5, 2026
  21. Derrick StoleeNov 5, 2026
  22. Patrick SteinhardtNov 5, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.