Re: [PATCH 00/10] commit-graph: several refactorings for writing commit graphs
On Thu, Nov 05, 2026 at 10:18:51AM -0500, Derrick Stolee wrote:
Show 22 quoted lines
> On 11/5/2026 8:57 AM, Patrick Steinhardt wrote:
> > On Wed, Nov 04, 2026 at 11:37:11AM -0500, Derrick Stolee wrote:
> >> On 11/4/2026 10:57 AM, Patrick Steinhardt wrote:
> >>> Hi,
> >>>
> >>> this patch series includes several small cleanups for the interfaces for
> >>> writing commit graphs. Most importantly, the series refactors options so
> >>> that they all get passed via `struct commit_graph_write_options`. These
> >>> cleanups are split out of a bigger change to make reading and writing
> >>> commit-graphs pluggable via the object database bakcend.
> >> These cleanups look great. They are carefully constructed to be as
> >> simple as possible at each step. It's good to bring some of these
> >> conventions into a more modern style and to simplify things in the
> >> process.
> >
> > Ah, by the way, one thing I forgot: I noticed this recently already, but
> > you don't reply-to-all and thus lose the Cc's on your replies. That made
> > me miss a couple of your replies already, so I'd appreciate it if you
> > could keep them.
> Sorry about that. I learned that Thunderbird replaced the "Reply All"
> button with a "Reply List" button that led to this unintentional
> behavior. I'll figure out how to change that default.
The joy of random UI updates.
Patrick