From: Kristofer Karlsson Date: Thu, 05 Nov 2026 15:07:18 GMT Subject: Re: [PATCH 06/10] commit-graph: move remaining write parameters into options Message-ID: In-Reply-To: On Thu, 5 Nov 2026 at 14:21, Patrick Steinhardt wrote: > > I was wondering whether we want to maybe introduce a tagged union where > it becomes implicitly clear that some of the options only apply to a > specific mode. Something like this: > [...] > > I wasn't really sure whether that complexity is really worth it, so for > now I decided to not pursue it. I think I still tend to stick with that > decision for now, but it's maybe something to keep in mind for the > future? Yes, I agree that it's already clean enough. If this code ever moves to Rust, an enum with the relevant data would be nice though. Thanks, Kristofer