Re: [PATCH] refs: fix loose-ref seeking across directory boundaries
- From
Harald Nordgren <haraldnordgren@gmail.com>
- Date
- Oct 15, 2026, 21:17 UTC
- Message-ID
- <CAHwyqnWX-3NXtFkKZvKeGweNqYFOp+A5NLgf+aO2iuwg_c2t7Q@mail.gmail.com>
- In-Reply-To
- <xmqqse26n5fa.fsf@gitster.g>
Show 13 quoted lines
> > The general idea looks sound. > > > >> + if test "$storage" = mixed > >> + then > >> + git pack-refs --all || return 1 > >> + fi && > > > > I don't see any reason why a test would need an if block, we know what data we > > expect, no? > > This is three tests implemented as a single test with a for-loop > around it. The variable instructs the single test_expect_success > to behave slightly differently depending on its setting.
I realize now that I didn't read the code properly. I didn't expect to see a loop encapsulating a call to test_expect_success. That explains the if case as well.
Harald