git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] refs: fix loose-ref seeking across directory boundaries

From
Harald Nordgren <haraldnordgren@gmail.com>
Date
Oct 15, 2026, 21:17 UTC
Message-ID
<CAHwyqnWX-3NXtFkKZvKeGweNqYFOp+A5NLgf+aO2iuwg_c2t7Q@mail.gmail.com>
In-Reply-To
<xmqqse26n5fa.fsf@gitster.g>
Show 13 quoted lines
> > The general idea looks sound.
> >
> >> +                    if test "$storage" = mixed
> >> +                    then
> >> +                            git pack-refs --all || return 1
> >> +                    fi &&
> >
> > I don't see any reason why a test would need an if block, we know what data we
> > expect, no?
>
> This is three tests implemented as a single test with a for-loop
> around it.  The variable instructs the single test_expect_success
> to behave slightly differently depending on its setting.

I realize now that I didn't read the code properly. I didn't expect to see a loop encapsulating a call to test_expect_success. That explains the if case as well.

Harald
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 11 in “refs: fix loose-ref seeking across directory boundaries”
  1. refs: fix loose-ref seeking across directory boundariesVenkat Ragavan via GitGitGadget, Oct 15, 2026
  2. Harald NordgrenOct 15, 2026
  3. D. Ben KnobleOct 15, 2026
  4. Junio C HamanoOct 15, 2026
  5. Harald NordgrenOct 15, 2026
  6. Junio C HamanoOct 27, 2026
  7. Patrick SteinhardtOct 28, 2026
  8. Junio C HamanoOct 28, 2026
  9. Patrick SteinhardtOct 28, 2026
  10. D. Ben KnobleOct 15, 2026
  11. Venkat RagavanOct 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.