git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] refs: fix loose-ref seeking across directory boundaries

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 28, 2026, 08:58 UTC
Message-ID
<auG5NTowgVZG9L2Q@pks.im>
In-Reply-To
<xmqqzevyg4w7.fsf@gitster.g>
On Tue, Oct 27, 2026 at 03:22:48PM -0700, Junio C Hamano wrote:
Show 21 quoted lines
> "Venkat Ragavan via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> > From: Venkat Ragavan S <mail2venkat21@gmail.com>
> >
> > When seeking through loose refs, cache_ref_iterator_seek() compares
> > each directory component without its trailing slash. This can confuse
> > a directory with a similarly named ref that sorts before it.
> > ...
> > Add regression tests for shared-prefix names, missing nested markers,
> > and markers beyond the end of the ref listing, using loose, packed,
> > and mixed refs.
> >
> > Signed-off-by: Venkat Ragavan S <mail2venkat21@gmail.com>
> > ---
> >     refs: fix loose-ref seeking across directory boundaries
> 
> I overlooked this topic, but re-reading the discussion, aside from a
> test that confused a reader, it seems the topic was already ready to
> go?
> 
> Any objections to the idea of making the topic ready for 'next'?

Sorry, I lost track of this patch series, but I've reviewed it now. Overall this looks good, but I wonder whether this really should be split up into three patches because as far as I understand, this single patch solves three separate bugs at once.

Patrick
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 11 in “refs: fix loose-ref seeking across directory boundaries”
  1. refs: fix loose-ref seeking across directory boundariesVenkat Ragavan via GitGitGadget, Oct 15, 2026
  2. Harald NordgrenOct 15, 2026
  3. D. Ben KnobleOct 15, 2026
  4. Junio C HamanoOct 15, 2026
  5. Harald NordgrenOct 15, 2026
  6. Junio C HamanoOct 27, 2026
  7. Patrick SteinhardtOct 28, 2026
  8. Junio C HamanoOct 28, 2026
  9. Patrick SteinhardtOct 28, 2026
  10. D. Ben KnobleOct 15, 2026
  11. Venkat RagavanOct 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.