Re: [PATCH] refs: fix loose-ref seeking across directory boundaries
- From
- Venkat Ragavan <mail2venkat21@gmail.com>
- Date
- Oct 16, 2026, 03:19 UTC
- Message-ID
- <CAFuK-oarU1rZOcDzYr=YA1SNvfAzyB6LaXXCjtZV6WWGswOnyw@mail.gmail.com>
- In-Reply-To
- <CAFuK-obau8UkmVVs0xkuwjddkqftMxwcGnGR640YqjswGrTj3Q@mail.gmail.com>
[Resending as plain text after the mailing list rejected the HTML version.]
> I realize now that I didn't read the code properly. I didn't expect to > see a loop encapsulating a call to test_expect_success. That explains > the if case as well.
Thanks for following up, and thanks Junio for explaining the setup. Since the loop intentionally exercises loose, packed, and mixed ref layouts, I'll leave the test unchanged.
On Fri, Oct 16, 2026 at 8:47 AM Venkat Ragavan <mail2venkat21@gmail.com> wrote:
Show 31 quoted lines
> > > I realize now that I didn't read the code properly. I didn't expect to > > see a loop encapsulating a call to test_expect_success. That explains > > the if case as well. > > Thanks for following up, and thanks Junio for explaining the setup. Since > the loop intentionally exercises loose, packed, and mixed ref layouts, I’ll > leave the test unchanged. > > On Fri, Oct 16, 2026 at 2:47 AM Harald Nordgren <haraldnordgren@gmail.com> wrote: >> >> > > The general idea looks sound. >> > > >> > >> + if test "$storage" = mixed >> > >> + then >> > >> + git pack-refs --all || return 1 >> > >> + fi && >> > > >> > > I don't see any reason why a test would need an if block, we know what data we >> > > expect, no? >> > >> > This is three tests implemented as a single test with a for-loop >> > around it. The variable instructs the single test_expect_success >> > to behave slightly differently depending on its setting. >> >> I realize now that I didn't read the code properly. I didn't expect to >> see a loop encapsulating a call to test_expect_success. That explains >> the if case as well. >> >> >> Harald