From: Harald Nordgren Date: Thu, 15 Oct 2026 21:17:05 GMT Subject: Re: [PATCH] refs: fix loose-ref seeking across directory boundaries Message-ID: In-Reply-To: > > The general idea looks sound. > > > >> + if test "$storage" = mixed > >> + then > >> + git pack-refs --all || return 1 > >> + fi && > > > > I don't see any reason why a test would need an if block, we know what data we > > expect, no? > > This is three tests implemented as a single test with a for-loop > around it. The variable instructs the single test_expect_success > to behave slightly differently depending on its setting. I realize now that I didn't read the code properly. I didn't expect to see a loop encapsulating a call to test_expect_success. That explains the if case as well. Harald