Re: [PATCH] refs: fix loose-ref seeking across directory boundaries
- From
D. Ben Knoble <ben.knoble@gmail.com>
- Date
- Oct 15, 2026, 17:08 UTC
- Message-ID
- <CALnO6CAi_rh_JMOhL0wrHSYZQYCZZstVNFuTxCGCavBnBPe+oQ@mail.gmail.com>
- In-Reply-To
- <20261015133624.82112-1-haraldnordgren@gmail.com>
On Thu, Oct 15, 2026 at 10:20 AM Harald Nordgren <haraldnordgren@gmail.com> wrote: [snip]
Show 7 quoted lines
> > + if test "$storage" = mixed > > + then > > + git pack-refs --all || return 1 > > + fi && > > I don't see any reason why a test would need an if block, we know what data we > expect, no?
I didn't examine too closely, but this test is wrapped in a loop over the storage variable that appears to determine whether and when we pack-refs, so I think the conditional makes sense for that?
-- D. Ben Knoble