Re: [PATCH v3 1/3] Add Travis CI support

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Oct 12, 2015, 19:53 UTC
Message-ID: <CAHGBnuN+sBptYQo2T03-Ja1E_6Q3SdT7dBEVPOQXupvDU3Ot1Q@mail.gmail.com>
In-Reply-To: <61B448FB-DB61-42B6-ACDF-181F76169061@gmail.com>

On Mon, Oct 12, 2015 at 9:43 PM, Lars Schneider <larsxschneider@gmail.com> wrote:

Show 12 quoted lines

>> Reading through Travis' docs [3] again, "before_script" is documented
>> to "return a non-zero exit code, the build is errored and stops
>> immediately", while "script" is documented as "returns a non-zero exit
>> code, the build is failed, but continues to run before being marked as
>> failed". As it does not make much sense to continue the build or even
>> start testing if the build failed, maybe it's indeed best to do:
>>
>> before_script: make configure && ./configure && make
>>
>> script: make --quiet test
>
> Ok, then I will make it so :-)

Also, this has the added benefit of being quickly able to see how much time building vs testing took. As these two are the big blocks, we'd want to optimize both steps for time, and it's easier to see what we gain e.g. from a possible build-time improvement if these steps are listed individually in the Travis log.

-- 
Sebastian Schuberth