Re: [PATCH v3 1/3] Add Travis CI support

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Oct 12, 2015, 08:05 UTC
Message-ID: <561B69AE.8050403@gmail.com>
In-Reply-To: <1444586102-82557-2-git-send-email-larsxschneider@gmail.com>

On 10/11/2015 19:55, larsxschneider@gmail.com wrote:

> +      sudo apt-get update -qq
> +      sudo apt-get install -y apt-transport-https
> +      sudo apt-get install perforce-server git-lfs

Why no "-y" also in this line, or append these to the previous line?

Or maybe even better, like [1] does, also use "--qq" (which implies "-y") for "apt-get install"?

Show 5 quoted lines

> +install: make configure && ./configure
> +
> +before_script: make
> +
> +script: make --quiet test

Semantically, it does not seem correct to me that configuarion goes to the install step. As "make test" will build git anyway, I'd instead propose to get rid of "install" and just say:

before_script: make configure && ./configure

script: make --quiet test

[1] https://github.com/git/git/pull/154/files

Regards, Sebastian