Re: [PATCH v3 1/3] Add Travis CI support

From: Lars Schneider <larsxschneider@gmail.com>
Date: Oct 12, 2015, 19:40 UTC
Message-ID: <B85D5671-9F8C-452E-87B9-EB4DE3C85955@gmail.com>
In-Reply-To: <xmqq37xgnkh0.fsf@gitster.mtv.corp.google.com>

On 12 Oct 2015, at 09:02, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Sebastian Schuberth <sschuberth@gmail.com> writes:
> 
>> Semantically, it does not seem correct to me that configuarion goes to
>> the install step. As "make test" will build git anyway, I'd instead
>> propose to get rid of "install" and just say:
>> 
>> before_script: make configure && ./configure
>> 
>> script: make --quiet test
> 
> Very good point.  Do we even need to do anything in the "install"
> target?  We aim to be able to testable without any installed Git,
> and not running "make install" at all, ever, would be one way to
> make sure that works.

The Travis CI "install" stage is independent of "make install". AFAIK you can use the Travis lifecycle stages pretty much as you want. However, I agree we should not use the "install" stage to avoid confusion.

Show 5 quoted lines

> This is a slightly related tangent, but we saw a few build issues
> reported recently on customized configurations like NO_PTHREAD.  If
> we are to start using automated tests, I wonder if we want to build
> (and optionally test) with various combinations of the customization
> options (e.g. NO_CURL, NO_OPENSSL, NO_MMAP, NO_IPV6, NO_PERL etc.)

This easy to do. However, the more we environment settings we define the longer the build runs. I created a test matrix that runs the following combinations: {Linux | OSX} * {gcc | clang} * {Default, NO_PTHREAD, NO_CURL, NO_OPENSSL, NO_MMAP, NO_IPV6, NO_PERL}

These result in 28 (= 2*2*7) combinations. I created a build without the "Default" environment (=24 combination) here: https://travis-ci.org/larsxschneider/git/builds/84978673

Should I add them them to the Travis CI patch?

Thanks, Lars