Re: [PATCH v3 1/3] Add Travis CI support

From: Lars Schneider <larsxschneider@gmail.com>
Date: Oct 12, 2015, 17:12 UTC
Message-ID: <BF182294-B896-4C2D-B371-74036BC522A2@gmail.com>
In-Reply-To: <561B69AE.8050403@gmail.com>

On 12 Oct 2015, at 01:05, Sebastian Schuberth <sschuberth@gmail.com> wrote:

Show 9 quoted lines

> On 10/11/2015 19:55, larsxschneider@gmail.com wrote:
> 
>> +      sudo apt-get update -qq
>> +      sudo apt-get install -y apt-transport-https
>> +      sudo apt-get install perforce-server git-lfs
> 
> Why no "-y" also in this line, or append these to the previous line?
> 
> Or maybe even better, like [1] does, also use "--qq" (which implies "-y") for "apt-get install"?

Agreed!

Show 12 quoted lines

> 
>> +install: make configure && ./configure
>> +
>> +before_script: make
>> +
>> +script: make --quiet test
> 
> Semantically, it does not seem correct to me that configuarion goes to the install step. As "make test" will build git anyway, I'd instead propose to get rid of "install" and just say:
> 
> before_script: make configure && ./configure
> 
> script: make --quiet test

I understand your point. I did this to make the "make" logs easily accessible (no option "--quite"). By default Travis CI automatically collapses the logs from all stages prior to the "script" stage. You can uncollapse these logs by clicking on the little triangle on the left border of the log. Therefore the "make" logs are available without noise.

Do you see value in "make" logs?

If yes then we could also do: before_script: make configure && ./configure && make

If no then I will take your suggestion.

Thanks, Lars