Re: [PATCH v6 2/7] submodule: don't pass empty string arguments to submodule--helper clone

From: Stefan Beller <sbeller@google.com>
Date: Feb 29, 2016, 23:14 UTC
Message-ID: <CAGZ79kZGzXHJ=oWfx8tsTEs=OU7c+KuV-G9sA7ABHQGQtXLOzQ@mail.gmail.com>
In-Reply-To: <1456786715-24256-3-git-send-email-jacob.e.keller@intel.com>

On Mon, Feb 29, 2016 at 2:58 PM, Jacob Keller <jacob.e.keller@intel.com> wrote:

Show 12 quoted lines

> From: Jacob Keller <jacob.keller@gmail.com>
>
> When --reference or --depth are unused, the current git-submodule.sh
> results in empty "" arguments appended to the end of the argv array
> inside git submodule--helper clone. This is not caught because the argc
> count is not checked today.
>
> Fix git-submodule.sh to only pass an argument when --reference or
> --depth are used, preventing the addition of two empty string arguments
> on the tail of the argv array.
>
> Signed-off-by: Jacob Keller <jacob.keller@gmail.com>

Reviewed-by: Stefan Beller <sbeller@google.com>