[PATCH v6 3/7] submodule: check argc count for git submodule--helper clone
- From
Jacob Keller <jacob.e.keller@intel.com>
- Date
- Feb 29, 2016, 22:58 UTC
- Message-ID
- <1456786715-24256-4-git-send-email-jacob.e.keller@intel.com>
- In-Reply-To
- <1456786715-24256-1-git-send-email-jacob.e.keller@intel.com>
From: Jacob Keller <jacob.keller@gmail.com>
Extra unused arguments to git submodule--helper clone subcommand were being silently ignored. Add a check to the argc count after options handling to ensure that no extra arguments were left on the argv array.
Signed-off-by: Jacob Keller <jacob.keller@gmail.com> --- builtin/submodule--helper.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index f4c3eff179b5..1e18075ed90f 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -194,6 +194,10 @@ static int module_clone(int argc, const char **argv, const char *prefix) argc = parse_options(argc, argv, prefix, module_clone_options, git_submodule_helper_usage, 0); + if (argc) + usage_with_options(git_submodule_helper_usage, + module_clone_options); + strbuf_addf(&sb, "%s/modules/%s", get_git_dir(), name); sm_gitdir = strbuf_detach(&sb, NULL);
-- 2.7.1.429.g45cd78e