Re: [PATCH v6 7/7] git: submodule honor -c credential.* from command line

From: Jacob Keller <jacob.keller@gmail.com>
Date: Mar 1, 2016, 22:03 UTC
Message-ID: <CA+P7+xrXiGT+Pv07C6oPx0+opdnHmd3SQWPo3tVYO2LvkqOtnw@mail.gmail.com>
In-Reply-To: <xmqqmvqi6mqb.fsf@gitster.mtv.corp.google.com>

On Tue, Mar 1, 2016 at 11:07 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

>> I could call expect_askpass here at each time but I don't think it
>> would be meaningful after a test_must_fail.
>
> Even if you call expect_askpass to check, another set_askpass is
> expected to start the next cycle anyway (unless we restructure the
> helpers around clear_askpass_query I alluded to, which I am not
> convinced is a good idea yet), so you'll still be asked "why another
> set_askpass to set the same 'wrong pass@host'?".
>
> So, I dunno.

Correct. I think it's not worth changing anything here now. The bigger solution to change to clear_askpass_query might be the right answer but it's a lot more involved.

Thanks, Jake