Re: [PATCH v6 7/7] git: submodule honor -c credential.* from command line

From: Jeff King <peff@peff.net>
Date: Mar 22, 2016, 19:23 UTC
Message-ID: <20160322192309.GA9782@sigill.intra.peff.net>
In-Reply-To: <20160322185628.GA19993@google.com>

On Tue, Mar 22, 2016 at 11:56:28AM -0700, Jonathan Nieder wrote:

Show 12 quoted lines

> This is failing for me when I use "git submodule add" with a remote
> helper I whitelisted with GIT_ALLOW_PROTOCOL, with current "next":
> 
>  $ bin-wrappers/git submodule add persistent-https://kernel.googlesource.com/pub/scm/git/git sm
>  Cloning into 'sm'...
>  error: bogus format in GIT_CONFIG_PARAMETERS
>  fatal: unable to parse command-line config
>  fatal: clone of 'persistent-https://kernel.googlesource.com/pub/scm/git/git' into submodule path 'sm' failed
> 
> sq_dequote_to_argv doesn't like the space at the beginning of
> $GIT_CONFIG_PARAMETERS.  Reverting 14111fc4 fixes it.  Known
> problem?

It's known that the parsing end is excessively picky, but not this particular bug. I found the problem; I'll have a patch out in a few minute after I write a test.

-Peff