Re: [PATCH v6 5/7] submodule: fix segmentation fault in submodule--helper clone

From: Jacob Keller <jacob.keller@gmail.com>
Date: Feb 29, 2016, 23:36 UTC
Message-ID: <CA+P7+xpOBa5sKQyZRVpGU9kxn9281vpnF4rUYyNOeBtWiqjjSg@mail.gmail.com>
In-Reply-To: <CAGZ79kZdct21==TeRoVr4NpgeKuHeUfpJ1Qsh+_tPJt0apr5DA@mail.gmail.com>

On Mon, Feb 29, 2016 at 3:20 PM, Stefan Beller <sbeller@google.com> wrote:

Show 15 quoted lines

>
> I think this bug was put in, by "literally" translating from shell,
> see ee8838d15776, where the shell code was rewritten to C,
> specially:
>
>  git clone $quiet ${depth:+"$depth"} -n ${reference:+"$reference"} \
>      --separate-git-dir "$gitdir" "$url" "$sm_path"
>
> Anything except url and path are done optionally, but url, and path not so.
> The C code was inspired by this and aligned.
>
> This patch makes sense to me,
> Thanks,
> Stefan
>

The only thing that bothers me is that git submodule--helper clone uses --path and --url instead of just taking two arguments after all the optional parameters. Traditionally options are supposed to be just that, optional. However given that long term we do not intend to keep submodule--helper, I am not too worried about how it works here.

Thanks, Jake