git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] don't use test_must_fail with grep

From
Stefan Beller <sbeller@google.com>
Date
Jan 3, 2017, 17:52 UTC
Message-ID
<CAGZ79kYbJuujDpT-3Dj6AFkZUaKUrj8NJ=WgBbT1YbgwTibc=Q@mail.gmail.com>
In-Reply-To
<20161231114412.23439-1-pranit.bauva@gmail.com>
On Sat, Dec 31, 2016 at 3:44 AM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
Show 5 quoted lines
> test_must_fail should only be used for testing git commands. To test the
> failure of other commands use `!`.
>
> Reported-by: Stefan Beller <sbeller@google.com>
> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>

Thanks for writing up such a patch! I had put it on my todo list, but you were faster on actually going through.

Thanks, Stefan

Previous: Junio C Hamano
Message 21 of 21 in “don't use test_must_fail with grep”
  1. don't use test_must_fail with grepPranit Bauva, Dec 31, 2016
  2. Luke DiamandJan 1, 2017
  3. Johannes SixtJan 1, 2017
  4. Luke DiamandJan 1, 2017
  5. Pranit BauvaJan 2, 2017
  6. Junio C HamanoJan 7, 2017
  7. Pranit BauvaJan 8, 2017
  8. 1/2 don't use test_must_fail with grepPranit Bauva, Jan 2, 2017
  9. 2/2 t9813: avoid using pipesPranit Bauva, Jan 2, 2017
  10. Stefan BellerJan 3, 2017
  11. Pranit BauvaJan 3, 2017
  12. Stefan BellerJan 3, 2017
  13. 1/2 don't use test_must_fail with grepPranit Bauva, Jan 3, 2017
  14. 2/2 t9813: avoid using pipesPranit Bauva, Jan 3, 2017
  15. Luke DiamandJan 4, 2017
  16. Pranit BauvaJan 4, 2017
  17. 1/2 don't use test_must_fail with grepPranit Bauva, Jan 8, 2017
  18. 2/2 t9813: avoid using pipesPranit Bauva, Jan 8, 2017
  19. Luke DiamandJan 9, 2017
  20. Junio C HamanoJan 9, 2017
  21. Stefan BellerJan 3, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.