git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/2] t9813: avoid using pipes

From
Pranit Bauva <pranit.bauva@gmail.com>
Date
Jan 4, 2017, 11:49 UTC
Message-ID
<CAFZEwPNuWf3WPY_WjTK8on1mzC58nZgmFhNdkmqQY5=-HE9XCg@mail.gmail.com>
In-Reply-To
<CAE5ih78vLwDubesnAxD=g3TzsbN0sQZae3McdFcwDAZfYYhXSg@mail.gmail.com>
Hey Luke,
On Wed, Jan 4, 2017 at 2:41 PM, Luke Diamand <luke@diamand.org> wrote:
Show 6 quoted lines
> On 3 January 2017 at 19:57, Pranit Bauva <pranit.bauva@gmail.com> wrote:
>> The exit code of the upstream in a pipe is ignored thus we should avoid
>> using it. By writing out the output of the git command to a file, we can
>> test the exit codes of both the commands.
>
> Do we also need to fix t9814-git-p4-rename.sh ?

I don't think so. As Johannes[1] and Stefan[2] pointed out, we should avoid upstream pipes for git. p4 can be treated as an "external command" just like grep/sed.

[1]: http://public-inbox.org/git/285ed013-5c59-0b98-7dc0-8f729587a313@kdbg.org/ [2]: http://public-inbox.org/git/CAGZ79kZRFLzD7wcAnFvke9vBxxTAgE7=Ud7F_O95EfkWqz=LJw@mail.gmail.com/

Previous: Luke DiamandNext: Pranit Bauva
Message 16 of 21 in “don't use test_must_fail with grep”
  1. don't use test_must_fail with grepPranit Bauva, Dec 31, 2016
  2. Luke DiamandJan 1, 2017
  3. Johannes SixtJan 1, 2017
  4. Luke DiamandJan 1, 2017
  5. Pranit BauvaJan 2, 2017
  6. Junio C HamanoJan 7, 2017
  7. Pranit BauvaJan 8, 2017
  8. 1/2 don't use test_must_fail with grepPranit Bauva, Jan 2, 2017
  9. 2/2 t9813: avoid using pipesPranit Bauva, Jan 2, 2017
  10. Stefan BellerJan 3, 2017
  11. Pranit BauvaJan 3, 2017
  12. Stefan BellerJan 3, 2017
  13. 1/2 don't use test_must_fail with grepPranit Bauva, Jan 3, 2017
  14. 2/2 t9813: avoid using pipesPranit Bauva, Jan 3, 2017
  15. Luke DiamandJan 4, 2017
  16. Pranit BauvaJan 4, 2017
  17. 1/2 don't use test_must_fail with grepPranit Bauva, Jan 8, 2017
  18. 2/2 t9813: avoid using pipesPranit Bauva, Jan 8, 2017
  19. Luke DiamandJan 9, 2017
  20. Junio C HamanoJan 9, 2017
  21. Stefan BellerJan 3, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.