git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] don't use test_must_fail with grep

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 7, 2017, 21:18 UTC
Message-ID
<xmqqy3ym36y2.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAFZEwPNbtamFfFy7vYXurpEWBDmRMyPB9+Ep-hm4uZVMREbq5Q@mail.gmail.com>
Pranit Bauva <pranit.bauva@gmail.com> writes:
Show 17 quoted lines
> Hey Johannes,
>
> On Sun, Jan 1, 2017 at 8:20 PM, Johannes Sixt <j6t@kdbg.org> wrote:
>> which makes me wonder: Is the message that we do expect not to occur
>> actually printed on stdout? It sounds much more like an error message, i.e.,
>> text that is printed on stderr. Wouldn't we need this?
>>
>>         git p4 commit >actual 2>&1 &&
>>         ! grep "git author.*does not match" actual &&
>>
>> -- Hannes
>
> This seems better! Since I am at it, I can remove the traces of pipes
> in an another patch.
>
> Regards,
> Pranit Bauva

I see v3 that has 2>&1 but according to Luke's comment ("the message comes from cat"), it shouldn't be there? I am behind clearing the backlog in my mailbox and I could tweak it out from v3 while queuing, or I may forget about it after looking at other topics ;-) in which case you may want to send v4 with the fix?

Previous: Pranit BauvaNext: Pranit Bauva
Message 6 of 21 in “don't use test_must_fail with grep”
  1. don't use test_must_fail with grepPranit Bauva, Dec 31, 2016
  2. Luke DiamandJan 1, 2017
  3. Johannes SixtJan 1, 2017
  4. Luke DiamandJan 1, 2017
  5. Pranit BauvaJan 2, 2017
  6. Junio C HamanoJan 7, 2017
  7. Pranit BauvaJan 8, 2017
  8. 1/2 don't use test_must_fail with grepPranit Bauva, Jan 2, 2017
  9. 2/2 t9813: avoid using pipesPranit Bauva, Jan 2, 2017
  10. Stefan BellerJan 3, 2017
  11. Pranit BauvaJan 3, 2017
  12. Stefan BellerJan 3, 2017
  13. 1/2 don't use test_must_fail with grepPranit Bauva, Jan 3, 2017
  14. 2/2 t9813: avoid using pipesPranit Bauva, Jan 3, 2017
  15. Luke DiamandJan 4, 2017
  16. Pranit BauvaJan 4, 2017
  17. 1/2 don't use test_must_fail with grepPranit Bauva, Jan 8, 2017
  18. 2/2 t9813: avoid using pipesPranit Bauva, Jan 8, 2017
  19. Luke DiamandJan 9, 2017
  20. Junio C HamanoJan 9, 2017
  21. Stefan BellerJan 3, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.