From: Stefan Beller <sbeller@google.com>
Date: Tue, 03 Jan 2017 17:52:35 GMT
Subject: Re: [PATCH] don't use test_must_fail with grep
Message-ID: <CAGZ79kYbJuujDpT-3Dj6AFkZUaKUrj8NJ=WgBbT1YbgwTibc=Q@mail.gmail.com>
In-Reply-To: <20161231114412.23439-1-pranit.bauva@gmail.com>

On Sat, Dec 31, 2016 at 3:44 AM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
> test_must_fail should only be used for testing git commands. To test the
> failure of other commands use `!`.
>
> Reported-by: Stefan Beller <sbeller@google.com>
> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>

Thanks for writing up such a patch!
I had put it on my todo list, but you
were faster on actually going through.

Thanks,
Stefan