Re: [PATCH] don't use test_must_fail with grep

From: Pranit Bauva <pranit.bauva@gmail.com>
Date: Jan 2, 2017, 13:40 UTC
Message-ID: <CAFZEwPNbtamFfFy7vYXurpEWBDmRMyPB9+Ep-hm4uZVMREbq5Q@mail.gmail.com>
In-Reply-To: <285ed013-5c59-0b98-7dc0-8f729587a313@kdbg.org>

Hey Johannes,

On Sun, Jan 1, 2017 at 8:20 PM, Johannes Sixt <j6t@kdbg.org> wrote:

Show 8 quoted lines

> which makes me wonder: Is the message that we do expect not to occur
> actually printed on stdout? It sounds much more like an error message, i.e.,
> text that is printed on stderr. Wouldn't we need this?
>
>         git p4 commit >actual 2>&1 &&
>         ! grep "git author.*does not match" actual &&
>
> -- Hannes

This seems better! Since I am at it, I can remove the traces of pipes in an another patch.

Regards, Pranit Bauva