git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 00/11] Fix direct filesystem access in various test files.

From
Han-Wen Nienhuys <hanwen@google.com>
Date
Aug 2, 2021, 16:53 UTC
Message-ID
<CAFQ2z_P=54uk-9r8rTcSvXd5g5Mj8S1GjziszanC6iNdTp4q8w@mail.gmail.com>
In-Reply-To
<xmqqr1fbx13k.fsf@gitster.g>
On Mon, Aug 2, 2021 at 6:28 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> > By listing the files before and after, we can make sure that the ref
> > storage wasn't changed.
>
> Meaning that we rely on the fact that we never append to an existing
> file?  A comment here would have helped.
Added some more explanation.

I addressed your comments for the other changes (but forgot to update the cover letter :-/ )

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Previous: Junio C HamanoNext: Han-Wen Nienhuys via GitGitGadget
Message 30 of 46 in “Fix direct filesystem access in various test files.”
  1. 0/6 Fix direct filesystem access in various test files.Han-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  2. 5/6 t3320: use git-symbolic-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  3. 1/6 t6050: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  4. 2/6 t1503: mark symlink test as REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  5. 6/6 t2402: use ref-store test helper to create broken symlinkHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  6. 3/6 t6120: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  7. 4/6 t7509: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  8. Junio C HamanoJul 19, 2021
  9. 00/11 Fix direct filesystem access in various test files.Han-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  10. 01/11 t6050: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  11. 03/11 t6120: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  12. 02/11 t1503: mark symlink test as REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  13. 05/11 t2402: use ref-store test helper to create broken symlinkHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  14. 04/11 t3320: use git-symbolic-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  15. 06/11 t1405: use 'git reflog exists' to check reflog existenceHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  16. Junio C HamanoJul 23, 2021
  17. 07/11 t1405: mark test for 'git pack-refs' as REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  18. Junio C HamanoJul 23, 2021
  19. 08/11 t1410: mark test as REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  20. Junio C HamanoJul 23, 2021
  21. 09/11 t7064: use update-ref -d to remove upstream branchHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  22. Junio C HamanoJul 23, 2021
  23. 10/11 t6500: use "ls -1" to snapshot ref database stateHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  24. 11/11 t6001: avoid direct file system accessHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  25. Junio C HamanoJul 23, 2021
  26. Junio C HamanoJul 23, 2021
  27. Han-Wen NienhuysAug 2, 2021
  28. Junio C HamanoAug 2, 2021
  29. Junio C HamanoAug 2, 2021
  30. Han-Wen NienhuysAug 2, 2021
  31. 00/11 Fix direct filesystem access in various test files.Han-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  32. 01/11 t6050: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  33. 03/11 t6120: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  34. 02/11 t1503: mark symlink test as REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  35. 04/11 t3320: use git-symbolic-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  36. 05/11 t2402: use ref-store test helper to create broken symlinkHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  37. 07/11 t1405: mark test for 'git pack-refs' as REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  38. 08/11 t1410: mark test as REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  39. 09/11 t7064: use update-ref -d to remove upstream branchHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  40. 06/11 t1405: use 'git reflog exists' to check reflog existenceHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  41. 11/11 t6001: avoid direct file system accessHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  42. 10/11 t6500: use "ls -1" to snapshot ref database stateHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  43. Junio C HamanoAug 2, 2021
  44. Junio C HamanoAug 2, 2021
  45. Han-Wen NienhuysAug 3, 2021
  46. Junio C HamanoJul 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.