git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/6] t6120: use git-update-ref rather than filesystem access

From
Han-Wen Nienhuys via GitGitGadget <gitgitgadget@gmail.com>
Date
Jul 19, 2021, 18:07 UTC
Message-ID
<695921cacb68dede0deef3a197bc9cd89c9cf2e3.1626718050.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1052.git.git.1626718050.gitgitgadget@gmail.com>
From: Han-Wen Nienhuys <hanwen@google.com>
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
---
 t/t6120-describe.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh
index 1a501ee09e1..bae2419150b 100755
--- a/t/t6120-describe.sh
+++ b/t/t6120-describe.sh
@@ -107,7 +107,8 @@ test_expect_success 'describe --contains defaults to HEAD without commit-ish' '
 check_describe tags/A --all A^0
 
 test_expect_success 'renaming tag A to Q locally produces a warning' "
-	mv .git/refs/tags/A .git/refs/tags/Q &&
+	git update-ref refs/tags/Q $(git rev-parse refs/tags/A) &&
+	git update-ref -d refs/tags/A &&
 	git describe HEAD 2>err >out &&
 	cat >expected <<-\EOF &&
 	warning: tag 'Q' is externally known as 'A'
@@ -135,7 +136,8 @@ test_expect_success 'abbrev=0 will not break misplaced tag (2)' '
 '
 
 test_expect_success 'rename tag Q back to A' '
-	mv .git/refs/tags/Q .git/refs/tags/A
+	git update-ref refs/tags/A $(git rev-parse refs/tags/Q) &&
+	git update-ref -d refs/tags/Q
 '
 
 test_expect_success 'pack tag refs' 'git pack-refs'
-- 
gitgitgadget
Previous: Han-Wen Nienhuys via GitGitGadgetNext: Han-Wen Nienhuys via GitGitGadget
Message 6 of 46 in “Fix direct filesystem access in various test files.”
  1. 0/6 Fix direct filesystem access in various test files.Han-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  2. 5/6 t3320: use git-symbolic-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  3. 1/6 t6050: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  4. 2/6 t1503: mark symlink test as REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  5. 6/6 t2402: use ref-store test helper to create broken symlinkHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  6. 3/6 t6120: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  7. 4/6 t7509: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  8. Junio C HamanoJul 19, 2021
  9. 00/11 Fix direct filesystem access in various test files.Han-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  10. 01/11 t6050: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  11. 03/11 t6120: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  12. 02/11 t1503: mark symlink test as REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  13. 05/11 t2402: use ref-store test helper to create broken symlinkHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  14. 04/11 t3320: use git-symbolic-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  15. 06/11 t1405: use 'git reflog exists' to check reflog existenceHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  16. Junio C HamanoJul 23, 2021
  17. 07/11 t1405: mark test for 'git pack-refs' as REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  18. Junio C HamanoJul 23, 2021
  19. 08/11 t1410: mark test as REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  20. Junio C HamanoJul 23, 2021
  21. 09/11 t7064: use update-ref -d to remove upstream branchHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  22. Junio C HamanoJul 23, 2021
  23. 10/11 t6500: use "ls -1" to snapshot ref database stateHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  24. 11/11 t6001: avoid direct file system accessHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  25. Junio C HamanoJul 23, 2021
  26. Junio C HamanoJul 23, 2021
  27. Han-Wen NienhuysAug 2, 2021
  28. Junio C HamanoAug 2, 2021
  29. Junio C HamanoAug 2, 2021
  30. Han-Wen NienhuysAug 2, 2021
  31. 00/11 Fix direct filesystem access in various test files.Han-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  32. 01/11 t6050: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  33. 03/11 t6120: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  34. 02/11 t1503: mark symlink test as REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  35. 04/11 t3320: use git-symbolic-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  36. 05/11 t2402: use ref-store test helper to create broken symlinkHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  37. 07/11 t1405: mark test for 'git pack-refs' as REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  38. 08/11 t1410: mark test as REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  39. 09/11 t7064: use update-ref -d to remove upstream branchHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  40. 06/11 t1405: use 'git reflog exists' to check reflog existenceHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  41. 11/11 t6001: avoid direct file system accessHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  42. 10/11 t6500: use "ls -1" to snapshot ref database stateHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  43. Junio C HamanoAug 2, 2021
  44. Junio C HamanoAug 2, 2021
  45. Han-Wen NienhuysAug 3, 2021
  46. Junio C HamanoJul 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.