git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 04/11] t3320: use git-symbolic-ref rather than filesystem access

From
Han-Wen Nienhuys via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 2, 2021, 16:53 UTC
Message-ID
<22bff0b0791ffa402b6cfb79ecaa589bf0617d85.1627923216.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1052.v3.git.git.1627923216.gitgitgadget@gmail.com>
From: Han-Wen Nienhuys <hanwen@google.com>
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
---
 t/t3320-notes-merge-worktrees.sh | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/t/t3320-notes-merge-worktrees.sh b/t/t3320-notes-merge-worktrees.sh
index 052516e6c6a..6b2d507f3e7 100755
--- a/t/t3320-notes-merge-worktrees.sh
+++ b/t/t3320-notes-merge-worktrees.sh
@@ -46,8 +46,9 @@ test_expect_success 'create some new worktrees' '
 test_expect_success 'merge z into y fails and sets NOTES_MERGE_REF' '
 	git config core.notesRef refs/notes/y &&
 	test_must_fail git notes merge z &&
-	echo "ref: refs/notes/y" >expect &&
-	test_cmp expect .git/NOTES_MERGE_REF
+	echo "refs/notes/y" >expect &&
+	git symbolic-ref NOTES_MERGE_REF >actual &&
+	test_cmp expect actual
 '
 
 test_expect_success 'merge z into y while mid-merge in another workdir fails' '
@@ -57,7 +58,7 @@ test_expect_success 'merge z into y while mid-merge in another workdir fails' '
 		test_must_fail git notes merge z 2>err &&
 		test_i18ngrep "a notes merge into refs/notes/y is already in-progress at" err
 	) &&
-	test_path_is_missing .git/worktrees/worktree/NOTES_MERGE_REF
+	test_must_fail git -C worktree symbolic-ref NOTES_MERGE_REF
 '
 
 test_expect_success 'merge z into x while mid-merge on y succeeds' '
@@ -68,8 +69,9 @@ test_expect_success 'merge z into x while mid-merge on y succeeds' '
 		test_i18ngrep "Automatic notes merge failed" out &&
 		grep -v "A notes merge into refs/notes/x is already in-progress in" out
 	) &&
-	echo "ref: refs/notes/x" >expect &&
-	test_cmp expect .git/worktrees/worktree2/NOTES_MERGE_REF
+	echo "refs/notes/x" >expect &&
+	git -C worktree2 symbolic-ref NOTES_MERGE_REF >actual &&
+	test_cmp expect actual
 '
 
 test_done
-- 
gitgitgadget
Previous: Han-Wen Nienhuys via GitGitGadgetNext: Han-Wen Nienhuys via GitGitGadget
Message 35 of 46 in “Fix direct filesystem access in various test files.”
  1. 0/6 Fix direct filesystem access in various test files.Han-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  2. 5/6 t3320: use git-symbolic-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  3. 1/6 t6050: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  4. 2/6 t1503: mark symlink test as REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  5. 6/6 t2402: use ref-store test helper to create broken symlinkHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  6. 3/6 t6120: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  7. 4/6 t7509: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 19, 2021
  8. Junio C HamanoJul 19, 2021
  9. 00/11 Fix direct filesystem access in various test files.Han-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  10. 01/11 t6050: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  11. 03/11 t6120: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  12. 02/11 t1503: mark symlink test as REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  13. 05/11 t2402: use ref-store test helper to create broken symlinkHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  14. 04/11 t3320: use git-symbolic-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  15. 06/11 t1405: use 'git reflog exists' to check reflog existenceHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  16. Junio C HamanoJul 23, 2021
  17. 07/11 t1405: mark test for 'git pack-refs' as REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  18. Junio C HamanoJul 23, 2021
  19. 08/11 t1410: mark test as REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  20. Junio C HamanoJul 23, 2021
  21. 09/11 t7064: use update-ref -d to remove upstream branchHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  22. Junio C HamanoJul 23, 2021
  23. 10/11 t6500: use "ls -1" to snapshot ref database stateHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  24. 11/11 t6001: avoid direct file system accessHan-Wen Nienhuys via GitGitGadget, Jul 22, 2021
  25. Junio C HamanoJul 23, 2021
  26. Junio C HamanoJul 23, 2021
  27. Han-Wen NienhuysAug 2, 2021
  28. Junio C HamanoAug 2, 2021
  29. Junio C HamanoAug 2, 2021
  30. Han-Wen NienhuysAug 2, 2021
  31. 00/11 Fix direct filesystem access in various test files.Han-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  32. 01/11 t6050: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  33. 03/11 t6120: use git-update-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  34. 02/11 t1503: mark symlink test as REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  35. 04/11 t3320: use git-symbolic-ref rather than filesystem accessHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  36. 05/11 t2402: use ref-store test helper to create broken symlinkHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  37. 07/11 t1405: mark test for 'git pack-refs' as REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  38. 08/11 t1410: mark test as REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  39. 09/11 t7064: use update-ref -d to remove upstream branchHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  40. 06/11 t1405: use 'git reflog exists' to check reflog existenceHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  41. 11/11 t6001: avoid direct file system accessHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  42. 10/11 t6500: use "ls -1" to snapshot ref database stateHan-Wen Nienhuys via GitGitGadget, Aug 2, 2021
  43. Junio C HamanoAug 2, 2021
  44. Junio C HamanoAug 2, 2021
  45. Han-Wen NienhuysAug 3, 2021
  46. Junio C HamanoJul 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.