From: Han-Wen Nienhuys <hanwen@google.com>
Date: Mon, 02 Aug 2021 16:53:43 GMT
Subject: Re: [PATCH v2 00/11] Fix direct filesystem access in various test files.
Message-ID: <CAFQ2z_P=54uk-9r8rTcSvXd5g5Mj8S1GjziszanC6iNdTp4q8w@mail.gmail.com>
In-Reply-To: <xmqqr1fbx13k.fsf@gitster.g>

On Mon, Aug 2, 2021 at 6:28 PM Junio C Hamano <gitster@pobox.com> wrote:
> > By listing the files before and after, we can make sure that the ref
> > storage wasn't changed.
>
> Meaning that we rely on the fact that we never append to an existing
> file?  A comment here would have helped.

Added some more explanation.

I addressed your comments for the other changes (but forgot to update
the cover letter :-/ )

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado