Re: [PATCH v2 00/11] Fix direct filesystem access in various test files.

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 2, 2021, 16:28 UTC
Message-ID: <xmqqr1fbx13k.fsf@gitster.g>
In-Reply-To: <CAFQ2z_PjEuy2Ngr_i7c8rT6xb4w2HBEUARqwR7azZO4zor-w7g@mail.gmail.com>

Han-Wen Nienhuys <hanwen@google.com> writes:

Show 16 quoted lines

> On Fri, Jul 23, 2021 at 7:44 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>> > This fixes a few test failures in the reftable series.
>>
>> The early part is already in 'next', and the new ones looked mostly
>> good.
>>
>> I didn't quite understand what was going on with "ls -1" though
>> (what does it even mean to "ls -1" enumerate only the filenames in
>> .git/reftable directory)?
>
>
> By listing the files before and after, we can make sure that the ref
> storage wasn't changed.

Meaning that we rely on the fact that we never append to an existing file? A comment here would have helped.

Thanks.