Re: [PATCH 04/18] t1401-symbolic-ref: avoid direct filesystem access

From

Han-Wen Nienhuys <hanwen@google.com>

Date

Apr 27, 2021, 09:13 UTC

Message-ID

<CAFQ2z_ObrsJ+SgvY8s0_ba-8aZxLwvXujT9ERPRnC_oAhJs+Zg@mail.gmail.com>

In-Reply-To

<20210419203835.GW2947267@szeder.dev>

On Mon, Apr 19, 2021 at 10:38 PM SZEDER Gábor <szeder.dev@gmail.com> wrote:

> > +     git symbolic-ref HEAD > actual &&
>
> Style nit: no space between redirection and filename, i.e. these
> should be '>expect' and '>actual'.

Done

> > +     ! git symbolic-ref NOTHEAD
>
> Please use 'test_must_fail git ...', because otherwise a segfault
> could go unnoticed.

Done.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado