Re: [PATCH v2 20/21] t4202: mark bogus head hash test with REFFILES

From: Han-Wen Nienhuys <hanwen@google.com>
Date: May 31, 2021, 14:21 UTC
Message-ID: <CAFQ2z_O6GufrNyfzPtddmW4KOQtMr6OhUZx_LUT2kcyQQ1sY6Q@mail.gmail.com>
In-Reply-To: <87eee1pfzk.fsf@evledraar.gmail.com>

On Thu, May 20, 2021 at 5:44 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 13 quoted lines

> > -test_expect_success 'log diagnoses bogus HEAD hash' '
> > +test_expect_success REFFILES 'log diagnoses bogus HEAD hash' '
> >       git init empty &&
> >       test_must_fail git -C empty log 2>stderr &&
> >       test_i18ngrep does.not.have.any.commits stderr &&
>
> Okey, they're correctly formed by design, but the first test here is
> just checking what happens when we do a "git log" on a repo with no
> commits. What does that have to do with reflog's guarantees that we have
> a valid-looking SHA in some entry in its database?
>
> Surely we also want to test for the same thing, the ref backend doesn't
> change that we have no commits or refs yet, no?

Done.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado