Re: [PATCH 04/18] t1401-symbolic-ref: avoid direct filesystem access

From

Han-Wen Nienhuys <hanwen@google.com>

Date

Apr 26, 2021, 18:01 UTC

Message-ID

<CAFQ2z_MLSb1kv42KcjWvWNy1FkmKiMiAtB_7VTc2TDgNKP1HfA@mail.gmail.com>

In-Reply-To

<87mttp1hv3.fsf@evledraar.gmail.com>

> It's not a cleanup routine that's failing, but potentially the "setup
> the next test" routine.
>
> In this case it's probably best to invert the logic, i.e. to make the
> tests do:
>
>         test_when_finished "rm -rf copy" &&
>         git clone . copy &&
>         <test-logic>
>
> Rather than:
>
>         reset_state &&
>         <test-logic>
>
> That also makes it more obvious what's setup and what/where tests rely
> on things carried forward from previous tests.

I'm using $TAR to recreate the repo scratch now. It appears to work.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado