Re: [PATCH 11/18] t1407: require REFFILES for for_each_reflog test
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Apr 27, 2021, 09:27 UTC
- Message-ID
- <CAFQ2z_NxM=Bkjb1rVo0eBpMUHP7fYN6mjTh3U1A=qmkVa9eXQw@mail.gmail.com>
- In-Reply-To
- <87sg3k40mc.fsf@evledraar.gmail.com>
On Wed, Apr 21, 2021 at 8:23 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 16 quoted lines
> > -test_expect_success 'for_each_reflog()' ' > > +test_expect_success REFFILES 'for_each_reflog()' ' > > echo $ZERO_OID > .git/logs/PSEUDO-MAIN && > > mkdir -p .git/logs/refs/bisect && > > echo $ZERO_OID > .git/logs/refs/bisect/random && > > Hrm, so already the first use of REFFILES has me questioning the need > for it. > > I mean obviously this depends on ref-files in the strict sense. > > .. > > * We have a PSEUDO-MAIN ref > * It's set to $ZERO_OID > * We have a $ZERO_OID in a refs/bisect/random
I've added some comments about what is happening here. The $ZERO_OID is irrelevant here. The test tries to verify that a per-worktree ref only appears in output of an invocation from that worktree. It's a useful test, but this needs to be tested in an entirely different way. (looks like setting logAllRefUpdates also doesn't trigger creating reflogs for pseudorefs.)
-- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado