git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 00/10] Column display

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Mar 11, 2012, 07:02 UTC
Message-ID
<CACsJy8BYDtAqJwAPK4nF+KvednNS8kX3TZGa+o-_=UsapA19oA@mail.gmail.com>
In-Reply-To
<87ehtbb5x7.fsf@thomas.inf.ethz.ch>
2012/3/2 Thomas Rast <trast@inf.ethz.ch>:
Show 25 quoted lines
> I ran valgrind over the tests in pu, and I'm seeing these errors
> presumably coming from this series:
>
> t3200-branch.out:==340== Invalid read of size 4
> t3200-branch.out:==340==    at 0x48E676: shrink_columns (column.c:101)
> t3200-branch.out:==340==    by 0x48EB76: display_table (column.c:200)
> t3200-branch.out:==340==    by 0x48ED1B: print_columns (column.c:241)
> t3200-branch.out:==340==    by 0x41967F: cmd_branch (branch.c:793)
> t3200-branch.out:==340==    by 0x40550B: run_builtin (git.c:308)
> t3200-branch.out:==340==    by 0x4056A6: handle_internal_command (git.c:468)
> t3200-branch.out:==340==    by 0x4057C0: run_argv (git.c:514)
> t3200-branch.out:==340==    by 0x40594D: main (git.c:589)
> t3200-branch.out:==340==  Address 0x57023ac is 0 bytes after a block of size 60 alloc'd
> t3200-branch.out:==340==    at 0x4C226FA: malloc (vg_replace_malloc.c:263)
> t3200-branch.out:==340==    by 0x521A11: xmalloc (wrapper.c:35)
> t3200-branch.out:==340==    by 0x48EAE8: display_table (column.c:193)
> t3200-branch.out:==340==    by 0x48ED1B: print_columns (column.c:241)
> t3200-branch.out:==340==    by 0x41967F: cmd_branch (branch.c:793)
> t3200-branch.out:==340==    by 0x40550B: run_builtin (git.c:308)
> t3200-branch.out:==340==    by 0x4056A6: handle_internal_command (git.c:468)
> t3200-branch.out:==340==    by 0x4057C0: run_argv (git.c:514)
> t3200-branch.out:==340==    by 0x40594D: main (git.c:589)
>
> and very similar errors in t7004-tag.out, t9002-column.out and
> t7508-status.out.  Can you look into it?

Thanks. There is a bug in shrink_columns() that causes invalid access. It wil be fixed in the next reroll.

-- 
Duy
Previous: Thomas RastNext: Junio C Hamano
Message 48 of 66 in “Column display”
  1. 00/11 Column displayNguyễn Thái Ngọc Duy, Feb 25, 2012
  2. 01/11 column: add API to print items in columnsNguyễn Thái Ngọc Duy, Feb 25, 2012
  3. 02/11 Add git-column and column mode parsingNguyễn Thái Ngọc Duy, Feb 25, 2012
  4. Ramsay JonesFeb 27, 2012
  5. Nguyen Thai Ngoc DuyFeb 28, 2012
  6. 03/11 Stop starting pager recursivelyNguyễn Thái Ngọc Duy, Feb 25, 2012
  7. 04/11 column: add columnar layoutNguyễn Thái Ngọc Duy, Feb 25, 2012
  8. 05/11 column: support columns with different widthsNguyễn Thái Ngọc Duy, Feb 25, 2012
  9. Junio C HamanoFeb 26, 2012
  10. 06/11 column: add column.ui for default column output settingsNguyễn Thái Ngọc Duy, Feb 25, 2012
  11. Junio C HamanoFeb 27, 2012
  12. Nguyen Thai Ngoc DuyFeb 27, 2012
  13. 07/11 help: reuse print_columns() for help -aNguyễn Thái Ngọc Duy, Feb 25, 2012
  14. 08/11 branch: add --columnNguyễn Thái Ngọc Duy, Feb 25, 2012
  15. 09/11 status: add --columnNguyễn Thái Ngọc Duy, Feb 25, 2012
  16. 10/11 column: support piping stdout to external git-column processNguyễn Thái Ngọc Duy, Feb 25, 2012
  17. 11/11 tag: add --columnNguyễn Thái Ngọc Duy, Feb 25, 2012
  18. Junio C HamanoFeb 26, 2012
  19. Nguyen Thai Ngoc DuyFeb 27, 2012
  20. Junio C HamanoFeb 27, 2012
  21. Junio C HamanoFeb 27, 2012
  22. Nguyen Thai Ngoc DuyFeb 27, 2012
  23. 00/10 Column displayNguyễn Thái Ngọc Duy, Feb 28, 2012
  24. 01/10 Add git-column for columnar displayNguyễn Thái Ngọc Duy, Feb 28, 2012
  25. Junio C HamanoFeb 28, 2012
  26. Nguyen Thai Ngoc DuyMar 2, 2012
  27. 02/10 Stop starting pager recursivelyNguyễn Thái Ngọc Duy, Feb 28, 2012
  28. Junio C HamanoFeb 28, 2012
  29. Junio C HamanoFeb 28, 2012
  30. Nguyen Thai Ngoc DuyFeb 29, 2012
  31. Junio C HamanoFeb 29, 2012
  32. Nguyen Thai Ngoc DuyFeb 29, 2012
  33. Junio C HamanoFeb 29, 2012
  34. 03/10 column: add columnar layoutNguyễn Thái Ngọc Duy, Feb 28, 2012
  35. Junio C HamanoFeb 28, 2012
  36. 04/10 column: add dense layout supportNguyễn Thái Ngọc Duy, Feb 28, 2012
  37. Junio C HamanoFeb 28, 2012
  38. Nguyen Thai Ngoc DuyMar 2, 2012
  39. Junio C HamanoMar 2, 2012
  40. 05/10 column: add column.ui for default column output settingsNguyễn Thái Ngọc Duy, Feb 28, 2012
  41. Junio C HamanoFeb 28, 2012
  42. 06/10 help: reuse print_columns() for help -aNguyễn Thái Ngọc Duy, Feb 28, 2012
  43. 07/10 branch: add --columnNguyễn Thái Ngọc Duy, Feb 28, 2012
  44. 08/10 status: add --columnNguyễn Thái Ngọc Duy, Feb 28, 2012
  45. 09/10 column: support piping stdout to external git-column processNguyễn Thái Ngọc Duy, Feb 28, 2012
  46. 10/10 tag: add --columnNguyễn Thái Ngọc Duy, Feb 28, 2012
  47. Thomas RastMar 2, 2012
  48. Nguyen Thai Ngoc DuyMar 11, 2012
  49. Junio C HamanoMar 12, 2012
  50. 00/9 Column displayNguyễn Thái Ngọc Duy, Mar 13, 2012
  51. Nguyen Thai Ngoc DuyMar 13, 2012
  52. 01/9 Add column layout skeleton and git-columnNguyễn Thái Ngọc Duy, Mar 13, 2012
  53. 02/9 Stop starting pager recursivelyNguyễn Thái Ngọc Duy, Mar 13, 2012
  54. 03/9 column: add columnar layoutNguyễn Thái Ngọc Duy, Mar 13, 2012
  55. 04/9 column: add dense layout supportNguyễn Thái Ngọc Duy, Mar 13, 2012
  56. 05/9 help: reuse print_columns() for help -aNguyễn Thái Ngọc Duy, Mar 13, 2012
  57. 06/9 branch: add --columnNguyễn Thái Ngọc Duy, Mar 13, 2012
  58. 07/9 status: add --columnNguyễn Thái Ngọc Duy, Mar 13, 2012
  59. 08/9 column: support piping stdout to external git-column processNguyễn Thái Ngọc Duy, Mar 13, 2012
  60. 09/9 tag: add --columnNguyễn Thái Ngọc Duy, Mar 13, 2012
  61. 10/9 ls-files: support --columnNguyễn Thái Ngọc Duy, Mar 13, 2012
  62. 11/9 column: support "denser" modeNguyễn Thái Ngọc Duy, Mar 13, 2012
  63. 12/9 column: support grouping entriesNguyễn Thái Ngọc Duy, Mar 13, 2012
  64. Junio C HamanoMar 13, 2012
  65. Nguyen Thai Ngoc DuyMar 14, 2012
  66. Junio C HamanoMar 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.