Re: [PATCH v7 02/10] Stop starting pager recursively

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 29, 2012, 04:51 UTC
Message-ID: <7vaa42w8by.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CACsJy8BfBP9m8rdEY3mk6g4G7n5LyFPvvNgNK2bkwC6L7qTDCg@mail.gmail.com>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

Show 11 quoted lines

> On Wed, Feb 29, 2012 at 10:37 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>>
>>> It does improve that situation, or at least it stops git from forking
>>> frantically.
>>
>> That "at least" sounds suspicious ;-) Do you mean that there is other
>> breakages in that mode of operation?
>
> Well, "shortlog -p" did not run $PAGER (i.e. less). I haven't had time
> to dig further.

Ok. for that matter,

    $ GIT_PAGER="git -p column" git tag --list

does not seem to use pager, either, so that may not be limited to shortlog, but in any case, I can see how the current code without your patch can fall into a fork loop, and your patch is an improvement, even if it may not yet be the whole solution.