Re: [PATCH v7 04/10] column: add dense layout support

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 28, 2012, 18:27 UTC
Message-ID: <7vty2azudf.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1330430331-19945-5-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

Show 9 quoted lines

> Normally, all items will be gone through once. The largest cell will set
> column width for all columns. With this strategy, one long item will
> stretch out all columns, wasting space in between them.
>
> With COL_DENSE enabled, it shrinks all columns to minimum, then attempts
> to push the last row's cells over to the next column with hope that
> everything still fits even there's one row less. The process is repeated
> until the new layout cannot fit in given width anymore, or there's only
> one row left (perfect!).

As you have given 4 bits for COL_MODE in the previous patch, I expected that this will be one of the mode that you can use, e.g. column-first dense, or row-first no-dense, with two more bits for operating modes. Not calling it COL_MODE_DENSE and assigning a "are we dense of not?" bit out of COL_MODE bits feels wrong.