Re: [PATCH v6 05/11] column: support columns with different widths

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

The contrast between this and the previous one is striking.

The addition of MODE_COLUMN and MODE_ROW are very well explained, and it will help people to later learn how to use the columns subsystem in their programs. But this does not even mention what "different widths" is, let alone explaining how to use it or if it is always on and the programs do not have to worry about (and have no control over) its behaviour.

I am guessing from the patch that you can tell the column subsystem to use a different mode, just like you can use MODE_COLUMN or MODE_ROW to instruct column/row major ordering, by using MODE_DENSE or something.

I am also reading from the patch that the "dense mode" allocates minimum necessary width dynamically to columns, which end up having different width. So "different" is not the more important part; "dense" is.

But the reader should not have to guess these things.