Re: [PATCH v4 27/27] count-objects: report unused files in $GIT_DIR/repos/...
On Wed, Mar 5, 2014 at 11:25 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 15 quoted lines
>> static void update_common_dir(struct strbuf *buf, int git_dir_len)
>> {
>> + /*
>> + * Remember to report_linked_checkout_garbage()
>> + * builtin/count-objects.c
>> + */
>
> I couldn't figure out why this comment was telling me to remember to
> report "linked checkout garbage" until I realized that you omitted the
> word "update" (as in "remember to update"). It might be clearer to say
> something along these lines:
>
> Keep synchronized with related list in
> builtin/count-objects.c:report_linked_checkout_garbage().
>I have a tendency to accidentally important words :)
Show 5 quoted lines
> Is it not possible or just too much of a hassle to maintain this list
> in just one place, as in a header which is included by these two
> files? The exceptions, such as 'log' and 'gc.pid', could be marked by
> a special character in the entry ("!gc.pid", for example) or any such
> scheme.It might work. Let me try.
--
Duy
Duy Nguyen <pclouds@gmail.com>