From: Duy Nguyen <pclouds@gmail.com>
Date: Wed, 05 Mar 2014 12:08:14 GMT
Subject: Re: [PATCH v4 27/27] count-objects: report unused files in $GIT_DIR/repos/...
Message-ID: <CACsJy8AP7n8psnfWfASVgmQQTgW1qiLYr7SjV-cnPBgNsK+j+A@mail.gmail.com>
In-Reply-To: <CAPig+cToTqJ4PPX3mvt0ftC-+Ncfiakz5dd_=xymM76T01z4fQ@mail.gmail.com>

On Wed, Mar 5, 2014 at 11:25 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>>  static void update_common_dir(struct strbuf *buf, int git_dir_len)
>>  {
>> +       /*
>> +        * Remember to report_linked_checkout_garbage()
>> +        * builtin/count-objects.c
>> +        */
>
> I couldn't figure out why this comment was telling me to remember to
> report "linked checkout garbage" until I realized that you omitted the
> word "update" (as in "remember to update"). It might be clearer to say
> something along these lines:
>
>     Keep synchronized with related list in
>     builtin/count-objects.c:report_linked_checkout_garbage().
>

I have a tendency to accidentally important words :)

> Is it not possible or just too much of a hassle to maintain this list
> in just one place, as in a header which is included by these two
> files? The exceptions, such as 'log' and 'gc.pid', could be marked by
> a special character in the entry ("!gc.pid", for example) or any such
> scheme.

It might work. Let me try.
-- 
Duy