Re: [PATCH v3 11/25] git-sh-setup.sh: use rev-parse --git-path to get $GIT_DIR/objects

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2014, 00:00 UTC
Message-ID: <xmqqvbw11l2x.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1392730814-19656-12-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 19 quoted lines

> If $GIT_COMMON_DIR is set, $GIT_OBJECT_DIRECTORY should be
> $GIT_COMMON_DIR/objects, not $GIT_DIR/objects. Just let rev-parse
> --git-path handle it.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  git-sh-setup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-sh-setup.sh b/git-sh-setup.sh
> index fffa3c7..fec9430 100644
> --- a/git-sh-setup.sh
> +++ b/git-sh-setup.sh
> @@ -343,7 +343,7 @@ then
>  		echo >&2 "Unable to determine absolute path of git directory"
>  		exit 1
>  	}
> -	: ${GIT_OBJECT_DIRECTORY="$GIT_DIR/objects"}
> +	: ${GIT_OBJECT_DIRECTORY="`git rev-parse --git-path objects`"}

$(...) is the preferred way over `...` in this codebase.

>  fi
>  
>  peel_committish () {