Re: [PATCH v3 01/25] path.c: make get_pathname() return strbuf instead of static buffer

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 1, 2014, 02:40 UTC
Message-ID: <CACsJy8AKu6UQURW-Zn=VE5WF3Yqfg329nsCoxiCt+nSJKfTW3g@mail.gmail.com>
In-Reply-To: <xmqqk3cq7kgm.fsf@gitster.dls.corp.google.com>

On Thu, Feb 20, 2014 at 6:26 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

> Is there a reason not to do just an equivalent of
>
>     #define git_pathdup mkpathdup
>
> and be done with it?  Am I missing something?
>

They have a subtle difference: mkpathdup() calls cleanup_path() while git_pathdup() does not. Without auditing all call sites, we can't be sure this difference is insignificant. So I keep both functions separate for now.

-- 
Duy

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.