Re: [PATCH v4 13/27] git-stash: avoid hardcoding $GIT_DIR/logs/....
On 2014-03-01 13.12, Nguyễn Thái Ngọc Duy wrote:
Show 15 quoted lines
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> git-stash.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/git-stash.sh b/git-stash.sh
> index ae7d16e..12d9b37 100755
> --- a/git-stash.sh
> +++ b/git-stash.sh
> @@ -183,7 +183,7 @@ store_stash () {
> fi
>
> # Make sure the reflog for stash is kept.
> - : >>"$GIT_DIR/logs/$ref_stash"
> + : >>"`git rev-parse --git-path logs/$ref_stash`" "$(git rev-parse --git-path logs/$ref_stash)"
Shouldn't we prefer $() over `` ?
Torsten Bögershausen <tboegi@web.de>