From: Duy Nguyen <pclouds@gmail.com>
Date: Sat, 01 Mar 2014 02:40:23 GMT
Subject: Re: [PATCH v3 01/25] path.c: make get_pathname() return strbuf instead of static buffer
Message-ID: <CACsJy8AKu6UQURW-Zn=VE5WF3Yqfg329nsCoxiCt+nSJKfTW3g@mail.gmail.com>
In-Reply-To: <xmqqk3cq7kgm.fsf@gitster.dls.corp.google.com>

On Thu, Feb 20, 2014 at 6:26 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Is there a reason not to do just an equivalent of
>
>     #define git_pathdup mkpathdup
>
> and be done with it?  Am I missing something?
>

They have a subtle difference: mkpathdup() calls cleanup_path() while
git_pathdup() does not. Without auditing all call sites, we can't be
sure this difference is insignificant. So I keep both functions
separate for now.
-- 
Duy