git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] completion: backwards compatibility fix

From
CMCarsten Mattner <carstenmattner@googlemail.com>
Date
May 19, 2012, 17:45 UTC
Message-ID
<CACY+HvpUXiK3_bmBZV7i_bgKOP7vSuYb2k4ARtqPGXzdpJfbPg@mail.gmail.com>
In-Reply-To
<20120519153134.GB6979@sigill.intra.peff.net>
On Sat, May 19, 2012 at 5:31 PM, Jeff King <peff@peff.net> wrote:
Show 19 quoted lines
> On Sat, May 19, 2012 at 09:54:28AM +0200, Carsten Mattner wrote:
>
>> >> Felipe Contreras (2):
>> >>   completion: rename _git and _gitk
>> >>   completion: add support for backwards compatibilit
>> >
>> > Thanks. This looks like the obviously correct solution. Even if we end
>> > up with a public _GIT_complete or whatever, the backwards-compatibility
>> > is worth it.
>>
>> Cool. Just though the patches now. Felipe, which variant should I use
>> to define _main_git completion for the alias g with the 2 patches
>> applied to git_completion.bash? Using bash-4.2.28.
>
> I think the point of the patches is that you can continue to use your
> same "complete ... -F _git g" line as always (with these patches you
> could also say "__git_complete g _main_git", but that is not backwards
> compatible to older versions, if you use the same bashrc on multiple
> machines).

Great, is that short form always enough with the patches applied and the non-internal function to use for future compatibility?

Previous: Jeff KingNext: Junio C Hamano
Message 10 of 14 in “completion: backwards compatibility fix”
  1. 0/2 completion: backwards compatibility fixFelipe Contreras, May 19, 2012
  2. 1/2 completion: rename _git and _gitkFelipe Contreras, May 19, 2012
  3. SZEDER GáborMay 22, 2012
  4. Junio C HamanoMay 22, 2012
  5. Felipe ContrerasMay 22, 2012
  6. 2/2 completion: add support for backwards compatibilityFelipe Contreras, May 19, 2012
  7. Jeff KingMay 19, 2012
  8. Carsten MattnerMay 19, 2012
  9. Jeff KingMay 19, 2012
  10. Carsten MattnerMay 19, 2012
  11. Junio C HamanoMay 20, 2012
  12. Carsten MattnerMay 20, 2012
  13. Felipe ContrerasMay 20, 2012
  14. Carsten MattnerMay 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.