Re: [PATCH 1/2] completion: rename _git and _gitk

From: SZEDER Gábor <szeder@ira.uka.de>
Date: May 22, 2012, 08:24 UTC
Message-ID: <20120522082406.GA6001@goldbirke>
In-Reply-To: <1337395295-29162-2-git-send-email-felipe.contreras@gmail.com>

Hi,

On Sat, May 19, 2012 at 04:41:34AM +0200, Felipe Contreras wrote:

Show 19 quoted lines

> Would be useful to provide backwards compatibility for _git. Also, zsh
> completion uses _git, and it cannot be changed.
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  contrib/completion/git-completion.bash |   10 +++++-----
>  t/t9902-completion.sh                  |    2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index cd92322..3cb106e 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2597,7 +2597,7 @@ _git_whatchanged ()
>  	_git_log
>  }
>  
> -_git ()
> +_main_git ()

> -_gitk ()
> +_main_gitk ()

After all those namespace discussions the names of these functions should start with _git or __git.

Gábor