git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] completion: rename _git and _gitk

From
Junio C Hamano <gitster@pobox.com>
Date
May 22, 2012, 18:00 UTC
Message-ID
<7vsjes3xl9.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120522082406.GA6001@goldbirke>
SZEDER Gábor <szeder@ira.uka.de> writes:
Show 8 quoted lines
>> -_git ()
>> +_main_git ()
>
>> -_gitk ()
>> +_main_gitk ()
>
> After all those namespace discussions the names of these functions
> should start with _git or __git.

As these are pure implementation internal details that are called from very limited places, I do not think Felipe minds a patch to update them.

Personally I would find _git_git or __git_git even more mysterious and begs one-liner comments above their definition, though.

Thanks.
Previous: SZEDER GáborNext: Felipe Contreras
Message 4 of 14 in “completion: backwards compatibility fix”
  1. 0/2 completion: backwards compatibility fixFelipe Contreras, May 19, 2012
  2. 1/2 completion: rename _git and _gitkFelipe Contreras, May 19, 2012
  3. SZEDER GáborMay 22, 2012
  4. Junio C HamanoMay 22, 2012
  5. Felipe ContrerasMay 22, 2012
  6. 2/2 completion: add support for backwards compatibilityFelipe Contreras, May 19, 2012
  7. Jeff KingMay 19, 2012
  8. Carsten MattnerMay 19, 2012
  9. Jeff KingMay 19, 2012
  10. Carsten MattnerMay 19, 2012
  11. Junio C HamanoMay 20, 2012
  12. Carsten MattnerMay 20, 2012
  13. Felipe ContrerasMay 20, 2012
  14. Carsten MattnerMay 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.