From: Carsten Mattner Date: Sat, 19 May 2012 17:45:47 GMT Subject: Re: [PATCH 0/2] completion: backwards compatibility fix Message-ID: In-Reply-To: <20120519153134.GB6979@sigill.intra.peff.net> On Sat, May 19, 2012 at 5:31 PM, Jeff King wrote: > On Sat, May 19, 2012 at 09:54:28AM +0200, Carsten Mattner wrote: > >> >> Felipe Contreras (2): >> >>   completion: rename _git and _gitk >> >>   completion: add support for backwards compatibilit >> > >> > Thanks. This looks like the obviously correct solution. Even if we end >> > up with a public _GIT_complete or whatever, the backwards-compatibility >> > is worth it. >> >> Cool. Just though the patches now. Felipe, which variant should I use >> to define _main_git completion for the alias g with the 2 patches >> applied to git_completion.bash? Using bash-4.2.28. > > I think the point of the patches is that you can continue to use your > same "complete ... -F _git g" line as always (with these patches you > could also say "__git_complete g _main_git", but that is not backwards > compatible to older versions, if you use the same bashrc on multiple > machines). Great, is that short form always enough with the patches applied and the non-internal function to use for future compatibility?