git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] completion: backwards compatibility fix

From
CMCarsten Mattner <carstenmattner@googlemail.com>
Date
May 20, 2012, 09:02 UTC
Message-ID
<CACY+HvqhJf6ywTaDgT5ie-3iBQAGwngTYPiCvKgw6mJB=1+fOg@mail.gmail.com>
In-Reply-To
<1337395295-29162-1-git-send-email-felipe.contreras@gmail.com>

On Sat, May 19, 2012 at 4:41 AM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 16 quoted lines
> Hi,
>
> These two patches are meant to fix the backwards compatibility of _git, and
> _gitk. This also helps my zsh's wrapper.
>
> Felipe Contreras (2):
>  completion: rename _git and _gitk
>  completion: add support for backwards compatibilit
>
>  contrib/completion/git-completion.bash |   22 +++++++++++++++++-----
>  t/t9902-completion.sh                  |    2 +-
>  2 files changed, 18 insertions(+), 6 deletions(-)
>
> --
> 1.7.10.2
>

Thanks Felipe. With the 2 patches applied all the following completion definitions work.

complete -o bashdefault -o default -o nospace -F _git g 2>/dev/null \
   || complete -o default -o nospace -F _git g
__git_complete g _git
__git_complete g _main_git

Ignoring backwards compatibility, which one would you suggest I use? Keep in mind that I originally copied the first long completion defintion from git-completion.bash a long time ago.

Previous: Junio C HamanoNext: Felipe Contreras
Message 12 of 14 in “completion: backwards compatibility fix”
  1. 0/2 completion: backwards compatibility fixFelipe Contreras, May 19, 2012
  2. 1/2 completion: rename _git and _gitkFelipe Contreras, May 19, 2012
  3. SZEDER GáborMay 22, 2012
  4. Junio C HamanoMay 22, 2012
  5. Felipe ContrerasMay 22, 2012
  6. 2/2 completion: add support for backwards compatibilityFelipe Contreras, May 19, 2012
  7. Jeff KingMay 19, 2012
  8. Carsten MattnerMay 19, 2012
  9. Jeff KingMay 19, 2012
  10. Carsten MattnerMay 19, 2012
  11. Junio C HamanoMay 20, 2012
  12. Carsten MattnerMay 20, 2012
  13. Felipe ContrerasMay 20, 2012
  14. Carsten MattnerMay 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.