Re: [PATCH 05/12] MINGW: git-compat-util.h: use inttypes.h for printf macros.
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Apr 28, 2014, 15:07 UTC
- Message-ID
- <CABPQNSawLpFQGuW-WV-e=v1U1OQ2BeZcatyBfbb4Xv6C3TvD_Q@mail.gmail.com>
- In-Reply-To
- <20140428150057.GA19002@seldon>
On Mon, Apr 28, 2014 at 5:00 PM, Marat Radchenko <marat@slonopotamus.org> wrote:
Show 9 quoted lines
> On Mon, Apr 28, 2014 at 04:53:52PM +0200, Erik Faye-Lund wrote: >> Just checking that I understand: Does this mean that we now require an >> MSVC-version that has stdint.h? If so, I'm not against such a case. >> IMO, the biggest benefit of using MSVC is not building on legacy >> systems, but being able to use it's debugger. And for that purpose >> it's probably OK to increase the required version. > > Ouch, that was not intentional. What minimal MSVC version is currently > supported and who decides if it is OK to increase required one?
I don't know what the oldest one anyone have ever used, but I don't think that matters. IMO, just noting it in the commit-message is good enough. Others might feel differently, though.
stdint.h is available in VS10 and onwards. contrib/buildsystems/Generators/Vcproj.pm generates project files for VS9.