Re: [PATCH 10/12] MINGW: config.mak.uname: drop USE_NED_ALLOCATOR
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Apr 28, 2014, 16:30 UTC
- Message-ID
- <20140428163009.GC13002@google.com>
- In-Reply-To
- <CABPQNSZD5jz1A8=zQvU4dYvNb-5M+TV50Uj+oVbWJs3YWBytHw@mail.gmail.com>
Erik Faye-Lund wrote:
> On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko <marat@slonopotamus.org> wrote:
Show 10 quoted lines
>> nedalloc was initially added in f0ed82 to fix slowness of standard WinXP >> memory allocator. Since WinXP is EOLed, this point is no longer valid. >> >> The actual reason behind this commit is incompatibility of malloc.c.h >> with MinGW-W64 headers. Alternative solution implies updating nedalloc >> to something newer. > > Did you measure that malloc on newer Windows-versions are actually > faster? AFAIK, malloc does a lot more inside the CRT than in the > kernel...
If it does turn out that nedalloc is not needed any more, please remove it from compat/, too. ;-)
Thanks for cleaning up.
Jonathan