Re: [PATCH 04/12] Makefile: introduce CROSS_COMPILE variable
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Apr 28, 2014, 17:34 UTC
- Message-ID
- <535e91317d381_45651483310d4@nysa.notmuch>
- In-Reply-To
- <20140428162536.GB13002@google.com>
Jonathan Nieder wrote:
> Marat Radchenko wrote:
> Does the effect of this setting depend on whether CC=gcc (i.e., is the > Makefile checking the value of CC and ignoring CROSS_COMPILE when it > is e.g. the Intel compiler)?
If the user is doing 'make CC=gcc', the CROSS_COMPILE setting shouldn't be appended.
Show 8 quoted lines
> [...] > > -STRIP ?= strip > > +STRIP = $(CROSS_COMPILE)strip > > Before, STRIP from the environment took precedence over STRIP from the > makefile. Switching to the more usual 'environment can't be trusted' > convention is a good change, but please mention it in the commit > message.
That's only if you run make without -e. If somebody wants the environment to be trusted, they should run 'make -e' in my opinion.
-- Felipe Contreras