Re: [PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Apr 28, 2014, 15:17 UTC
- Message-ID
- <CABPQNSa7buDJFYsaW1a51XoRnqZiVUYGSgfS1t-UiF7TnuWX5g@mail.gmail.com>
- In-Reply-To
- <20140428150436.GB19002@seldon>
On Mon, Apr 28, 2014 at 5:04 PM, Marat Radchenko <marat@slonopotamus.org> wrote:
Show 9 quoted lines
> On Mon, Apr 28, 2014 at 04:58:11PM +0200, Erik Faye-Lund wrote: >> On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko <marat@slonopotamus.org> wrote: >> > HAVE_LIBCHARSET_H and NO_R_TO_GCC_LINKER are not specific to >> > msysGit, they're general MinGW settings. >> >> Actually, HAVE_LIBCHARSET_H is. It's only present because we have >> libiconv installed. > > 1. What are other ways to provide iconv on MinGW?
I'm not sure I understand. To set HAVE_LIBCHARSET_H, we need to have libcharset.h. MinGW doesn't supply by default to my knowledge, so we get it from iconv. The THIS_IS_MSYSGIT file is there for us to be able to pick the right defaults for msysGit, and us having libcharset is indeed a msysGit-detail. Not all iconv-flavors supply libcharset.h, so this tells a particularity about the one we have in msysGit.
> 2. One can still completely disable iconv with NO_ICONV=1
Sure. And it does seem like the current setup assumes that anyone building for MinGW has iconv. But perhaps that's a mistake?
All in all, I think maybe the line between MinGW and msysGit is a bit blurry at the moment. On the other hand, I don't know of anyone else than Sebastian that builds outside of msysGit.
To be honest, I think the whole THIS_IS_MSYSGIT-block should have stayed downstream.